if color == "red" or "blue" is always True

Comments 5

1. LULucasVD17 Sep, 07:18 Solutionreplies: 1

   Python reads it as (color == "red") or ("blue"). A non-empty string is truthy, so the whole thing is always True.

   Write either:

   if color == "red" or color == "blue":
   if color in ("red", "blue"):

   The second is the Pythonic way.
   1. CHCharlieHOP17 Sep, 13:15

      The in version is so much nicer.
2. EMEmmaCodes18 Sep, 07:32

   One of the most common beginner bugs in every language that allows truthy strings. You're in good company.
3. LILiamByte18 Sep, 16:06replies: 1

   or also returns one of its values, not just True/False: name = user_input or "Anonymous" is a neat default.
   1. OLOllieGrant20 Sep, 07:33

      Careful with that default trick when 0 is a valid input though.